james/pgmon
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 3 Wiki Activity

Fix global variable placement

Browse Source
This commit is contained in:
James Campbell 2025-06-04 12:49:35 -04:00
parent cfe01eb63e
commit 8fe81e3ab3
Signed by: james
GPG Key ID: 2287C33A40DC906A
1 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/pgmon.py
View File

@ -518,7 +518,6 @@ def parse_version_rss(raw_rss, release):
This sets these global variables: This sets these global variables:
latest_version latest_version
latest_version_next_check
release_supported release_supported
It is expected that the caller already holds the latest_version_lock lock. It is expected that the caller already holds the latest_version_lock lock.
@ -528,7 +527,6 @@ def parse_version_rss(raw_rss, release):
release: The PostgreSQL release we care about (ex: 9.2, 14) release: The PostgreSQL release we care about (ex: 9.2, 14)
""" """
global latest_version global latest_version
global latest_version_next_check
global release_supported global release_supported
# Regular expressions for parsing the RSS document # Regular expressions for parsing the RSS document
@ -583,6 +581,8 @@ def get_latest_version():
Get the latest supported version of the major PostgreSQL release running on the server being monitored. Get the latest supported version of the major PostgreSQL release running on the server being monitored.
""" """
global latest_version_next_check
# If we don't know the latest version or it's past the recheck time, get the # If we don't know the latest version or it's past the recheck time, get the
# version from the PostgreSQL RSS feed. Only one thread needs to do this, so # version from the PostgreSQL RSS feed. Only one thread needs to do this, so
# they all try to grab the lock, and then make sure nobody else beat them to it. # they all try to grab the lock, and then make sure nobody else beat them to it.
@ -705,7 +705,10 @@ class SimpleHTTPRequestHandler(BaseHTTPRequestHandler):
self._reply( self._reply(
200, 200,
json.dumps( json.dumps(
{"latest": latest_version, "supported": 1 if release_supported else 0} {
"latest": latest_version,
"supported": 1 if release_supported else 0,
}
), ),
) )
except LatestVersionCheckError as e: except LatestVersionCheckError as e: